fix: don't query stopped containers by default #611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As remarked by @karlyan17 in #314, the configuration option-include-stopped
has no effect because the inclusion of stopped containers was hard set totrue
internally.Edit: the issue is actually a bit different.
The inclusion of stopped containers happen in two steps:
-include-stopped
)The second step works correctly and probably always have.
The first step is the one having an issue : docker-gen always get all the containers from the Docker API endpoint even when
-include-stopped
is not used. This does not impact-include-stopped
, but it means docker-gen always fetch more data than necessary from the Docker API endpoint when not using this feature.Fix #314