feat: Add debug log mask support #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGINX supports multiple debug masks to customize logging. We use Rust's type system to represent these as an enum and ease a developers usage. They can call the ngx_log_debug_mask with any of the supported enum elements. To aid in keeping in sync with NGINX primitives a unit test will fail when the current FIRST and LAST log masks do not align any longer.
ivanitskiy
reviewed
Jul 19, 2023
added 2 commits
July 19, 2023 14:41
- Prefer "///" comments - Reword ngx_log_debug_mask docs
|
Believe I have everything addressed. Let me know if you're ok and I'll merge. |
ivanitskiy
approved these changes
Jul 21, 2023
Build showed private references aren't resolved during macro expansion. Removing some of the DRY code to solve build.
f5yacobucci
force-pushed
the
issue-30-log-support
branch
from
7151e26 to
5d0d352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGINX supports multiple debug masks to customize logging.
We use Rust's type system to represent these as an enum and ease a developers usage. They can call the ngx_log_debug_mask with any of the supported enum elements.
To aid in keeping in sync with NGINX primitives a unit test will fail when the current FIRST and LAST log masks do not align any longer.
Checklist
Before creating a PR, run through this checklist and mark each as complete.