Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests not running on external PRs #297

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Fix tests not running on external PRs #297

merged 1 commit into from
Jan 10, 2023

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Jan 10, 2023 •
edited
Loading

Proposed changes

GitHub actions should now correctly skip plus scenarios only when the NGINX Plus license secrets are not present.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Jan 10, 2023
@alessfg alessfg added the bug Something isn't working label Jan 10, 2023
@alessfg alessfg added this to the 0.5.3 milestone Jan 10, 2023
@alessfg alessfg merged commit b065e7f into main Jan 10, 2023
@alessfg alessfg deleted the fix-plus-tests branch January 10, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alessfg alessfg

Labels
bug Something isn't working
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@alessfg