Change mappings value from a dictionary to a list in the default template #317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #316
Proposed changes
The current default template states that the
mappings
value of themap
directive expects a dictionary or a list of dictionaries, while in reality, it works only with a list. As adding secondary support for a single dictionary looks like overkill, I propose to change the template, so both the demo value and a comment reflect thatmappings
should be used with a list of dictionaries.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentdefaults/main/*.yml
,README.md
andCHANGELOG.md
)