-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop log unsupported "spdy", make "http2" a server level option. #346
Conversation
commit message is wrong >_< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I missed spdy
no longer being supported.
Re implementing the new http2
directives -- the way the templates are organized, each "module" has its own template. Your current placement is within the core
template, whereas the http2
directive should live inside its own module template. This helps in maintaining and tracking down any potential issues with the code further down the line.
I think the best location for the module would be before this macro block https://github.com/nginxinc/ansible-role-nginx-config/blob/main/templates/http/modules.j2#L23. You will then need to add the template to https://github.com/nginxinc/ansible-role-nginx-config/blob/main/templates/http/default.conf.j2. (There is no need to implement all the http2
directives right now, but creating its own template section will help with implementing the remaining directives further down the line 😄)
OK, will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I added a few suggestions re the wording in comments (to keep all comments as standard as possible) and fix some Jinja2 quirks that might lead to unnecessary whitespaces.
One more thing, can you update the Changelog? Thanks!
Co-authored-by: Alessandro Fael Garcia <alessfg@hotmail.com>
Co-authored-by: Alessandro Fael Garcia <alessfg@hotmail.com>
Co-authored-by: Alessandro Fael Garcia <alessfg@hotmail.com>
Co-authored-by: Alessandro Fael Garcia <alessfg@hotmail.com>
Co-authored-by: Alessandro Fael Garcia <alessfg@hotmail.com>
Co-authored-by: Alessandro Fael Garcia <alessfg@hotmail.com>
Co-authored-by: Alessandro Fael Garcia <alessfg@hotmail.com>
Proposed changes
Removes long abandoned SPDY listening socket option.
Also moves http2 to a server level
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentdefaults/main/*.yml
,README.md
andCHANGELOG.md
)