Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nested dictionaries with lists #76

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Replace nested dictionaries with lists #76

merged 2 commits into from
Feb 11, 2021

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented Feb 11, 2021

Proposed changes

Modify servers, servers.listen, server.locations, upstream and upstream.servers from nested dictionaries in the http and stream configuration templates to lists, as well as modify the nginx_config_html_demo_template variable from a nested dictionary to a list. To update your templates, replace the aforementioned nested dictionary keys by lists (place a dash in front of the topmost nested value within each aforementioned nested dictionary).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that all Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@alessfg alessfg self-assigned this Feb 11, 2021
@alessfg alessfg added breaking change Implies a breaking change enhancement Enhance an existing feature labels Feb 11, 2021
@alessfg alessfg added this to the 0.4.0 milestone Feb 11, 2021
@alessfg alessfg merged commit 3eba649 into main Feb 11, 2021
@alessfg alessfg deleted the dictionary-to-list branch February 11, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Implies a breaking change enhancement Enhance an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant