Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: Work around Alpine Linux wget struggles with github.com. #837

Closed
wants to merge 1 commit into from

Conversation

thresheek
Copy link
Collaborator

@thresheek thresheek commented Aug 28, 2023

Proposed changes

Looks like something is subtly broken or triggers GitHub bot detection on Alpine Linux wget, as all request to tarballs result in 403.

$ docker run -ti --rm alpine:3.18 sh -c "apk add wget && wget https://github.com/openresty/echo-nginx-module/archive/v0.62.tar.gz" fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/main/aarch64/APKINDEX.tar.gz fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/community/aarch64/APKINDEX.tar.gz (1/4) Installing libunistring (1.1-r1)
(2/4) Installing libidn2 (2.3.4-r1)
(3/4) Installing pcre2 (10.42-r1)
(4/4) Installing wget (1.21.4-r0)
Executing busybox-1.36.1-r2.trigger
OK: 11 MiB in 19 packages
--2023-08-28 21:10:42--  https://github.com/openresty/echo-nginx-module/archive/v0.62.tar.gz Resolving github.com (github.com)... 192.30.255.113 Connecting to github.com (github.com)|192.30.255.113|:443... connected. HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/openresty/echo-nginx-module/tar.gz/refs/tags/v0.62 [following] --2023-08-28 21:10:43--  https://codeload.github.com/openresty/echo-nginx-module/tar.gz/refs/tags/v0.62 Resolving codeload.github.com (codeload.github.com)... 192.30.255.121 Connecting to codeload.github.com (codeload.github.com)|192.30.255.121|:443... connected. HTTP request sent, awaiting response... 403 Forbidden 2023-08-28 21:10:43 ERROR 403: Forbidden.

Surprisingly, busybox wget works, so let's just use that.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • I have run ./update.sh and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

Looks like something is subtly broken or triggers GitHub bot detection
on Alpine Linux wget, as all request to tarballs result in 403.

$ docker run -ti --rm alpine:3.18 sh -c "apk add wget && wget https://github.com/openresty/echo-nginx-module/archive/v0.62.tar.gz"
fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/main/aarch64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.18/community/aarch64/APKINDEX.tar.gz
(1/4) Installing libunistring (1.1-r1)
(2/4) Installing libidn2 (2.3.4-r1)
(3/4) Installing pcre2 (10.42-r1)
(4/4) Installing wget (1.21.4-r0)
Executing busybox-1.36.1-r2.trigger
OK: 11 MiB in 19 packages
--2023-08-28 21:10:42--  https://github.com/openresty/echo-nginx-module/archive/v0.62.tar.gz
Resolving github.com (github.com)... 192.30.255.113
Connecting to github.com (github.com)|192.30.255.113|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/openresty/echo-nginx-module/tar.gz/refs/tags/v0.62 [following]
--2023-08-28 21:10:43--  https://codeload.github.com/openresty/echo-nginx-module/tar.gz/refs/tags/v0.62
Resolving codeload.github.com (codeload.github.com)... 192.30.255.121
Connecting to codeload.github.com (codeload.github.com)|192.30.255.121|:443... connected.
HTTP request sent, awaiting response... 403 Forbidden
2023-08-28 21:10:43 ERROR 403: Forbidden.

Surprisingly, busybox wget works, so let's just use that.
@thresheek
Copy link
Collaborator Author

No, this is clearly wrong. See also https://github.com/orgs/community/discussions/65227 - looks like we need to wait to get this fixed on Github side.

@thresheek thresheek closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant