Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust where grafana password is stored for kubeconfig deploys #206

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

qdzlug
Copy link
Contributor

@qdzlug qdzlug commented Nov 15, 2022

Proposed changes

This minor change updates where the kubeconfig deployments store the prometheus/grafana password; it is now
stored in the secrets project, not the main project configuration.

Closes #204

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • [ X I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Copy link
Contributor

@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐳 👍

@qdzlug
Copy link
Contributor Author

qdzlug commented Nov 15, 2022

I'm not sure why the runner tests are failing, as they are running fine for me on these platforms locally. Going to merge and move on to the next bug; will come back to this if it persists.

@qdzlug qdzlug merged commit 036b5b6 into nginxinc:master Nov 15, 2022
@qdzlug qdzlug deleted the jaypatch branch November 15, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fail to deploy prometheus
2 participants