Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumping dependency versions #25

Merged
merged 1 commit into from
Jul 14, 2021
Merged

chore: bumping dependency versions #25

merged 1 commit into from
Jul 14, 2021

Conversation

dekobon
Copy link
Collaborator

@dekobon dekobon commented Jul 12, 2021

Proposed changes

This change upgrades the pulumi python module dependency because it was being intentionally held back due to a bug. Moreover, it changes the format of version matching such that all dependencies will only install minor version updates.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

This change upgrades the pulumi python module dependency because it
was being intentionally held back due to a bug. Moreover, it changes
the format of version matching such that all dependencies will only
install minor version updates.
@dekobon dekobon requested a review from qdzlug July 12, 2021 23:37
Copy link
Contributor

@qdzlug qdzlug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; I tested these changes with my anthos branch and all went swimmingly.

@dekobon dekobon merged commit 951ed7a into master Jul 14, 2021
@dekobon dekobon deleted the requirements_bump branch July 14, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants