fix: decrypt postgres password for use in connection string #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekobon
requested changes
Jul 27, 2021
pulumi/aws/anthos/__main__.py
Outdated
| # The database password is a secret, and in order to use it in a string concat | ||
| # we need to decrypt the password with Output.unsecret() before we use it. | ||
| # This function provides the logic to accomplish this. | ||
| accounts_db_uri = pulumi.Output.unsecret(accounts_pwd).apply( |
There was a problem hiding this comment.
Consider modifying this such that Pulumi continues to use secrets:
def create_pg_uri(password_object):
user = str(accounts_admin)
password = str(password_object)
database = str(accounts_db)
uri = f'postgresql://{user}:{password}@accounts-db:5432/{database}'
return pulumi.Output.secret(uri)
accounts_db_uri = pulumi.Output.unsecret(accounts_pwd).apply(create_pg_uri)There was a problem hiding this comment.
Fixed; that's a great example construct for this use case.
pulumi/aws/anthos/__main__.py
Outdated
| @@ -141,7 +147,7 @@ def add_namespace(obj): | |||
| }) | |||
|
|
|||
| # Configuration Values are stored in the configuration: | |||
| # ../config/Pulumi.STACKNAME.yaml | |||
| # ./config/Pulumi.STACKNAME.yaml | |||
| config = pulumi.Config('anthos') | |||
| demo_pwd = config.require_secret('demo_pwd') | |||
|
|
|||
There was a problem hiding this comment.
Let's delete the demo_login and demo_pwd bits.
There was a problem hiding this comment.
Done and updated in all other locations and configs.
|
Running full test overnight. |
dekobon
approved these changes
Jul 27, 2021
dekobon
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This addresses a bug introduced with #30 - the password is part of the connection string, but pulumi does not decrypt it for use in the string concatenation needed to build it. This has been fixed by using the
Output.unsecretmethod.Checklist
Before creating a PR, run through this checklist and mark each as complete.