terminate milestone api call (#5864)

nginxinc · Jun 26, 2024 · d7c849e · d7c849e
1 parent 1499b30
commit d7c849e
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -276,9 +276,14 @@ jobs:
         with:
           ref: ${{ inputs.release_branch }}
 
+      - name: Configure AWS Credentials
+        uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2
+        with:
+          aws-region: us-east-1
+          role-to-assume: ${{ secrets.AWS_ROLE_MARKETPLACE }}
+
       - name: Publish to AWS Marketplace
         uses: nginxinc/aws-marketplace-publish@be512a7ae9666098bc4429a1afa27a11be6a3995 # v1.0.3
-        continue-on-error: true
         with:
           version: ${{ inputs.nic_version }}
           product-id: ${{ secrets[matrix.product_id] }}
@@ -423,7 +428,7 @@ jobs:
             '.[] | select(.title == $version) | .number')
           if ! ${{ inputs.dry_run }}; then
             gh api --method PATCH -H "Accept: application/vnd.github.v3+json" \
-              /repos/${{ github.repository }}/milestones/${milestone_number} \
+              /repos/${{ github.repository }}/milestones/${milestone_number};
           else
             echo "Skipping closing Github Release milestone, DRY_RUN"
           fi