Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart: requests and limits on init container #3804

Closed
bj0rn opened this issue Apr 21, 2023 · 2 comments · Fixed by #4651
Closed

Helm chart: requests and limits on init container #3804

bj0rn opened this issue Apr 21, 2023 · 2 comments · Fixed by #4651
Assignees
@oseoin
Labels
backlog Pull requests/issues that are backlog items help wanted Issues identified as good community contribution opportunities proposal An issue that proposes a feature request
Milestone
v3.4.0

Comments

@bj0rn
Copy link

bj0rn commented Apr 21, 2023

Is your feature request related to a problem? Please describe.
Gatekeeper in our cluster requires that a request/limit is set on all containers. When we set "readOnlyRootFilesystem: true" an init container is generated without a resource block.

https://github.com/nginxinc/kubernetes-ingress/blob/main/deployments/helm-chart/templates/controller-deployment.yaml#L257

Describe the solution you'd like
We want it to be possible to set resources on the init container that is generated when readOnlyRootFilesystem: true is set
@bj0rn bj0rn added the proposal An issue that proposes a feature request label Apr 21, 2023
@github-actions
Copy link

Hi @bj0rn thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@jasonwilliams14
Copy link
Contributor

@bj0rn Thank you for the request.
We will review and take a look on our side.

@danielnginx danielnginx added the backlog Pull requests/issues that are backlog items label May 4, 2023
@brianehlert brianehlert added the help wanted Issues identified as good community contribution opportunities label Jun 22, 2023
@vepatel vepatel added this to the v3.3.0 milestone Jul 6, 2023
@vepatel vepatel modified the milestones: v3.3.0, Candidates Sep 25, 2023
@brianehlert brianehlert modified the milestones: Candidates, v3.4.0 Nov 13, 2023
@oseoin oseoin self-assigned this Nov 13, 2023
@oseoin oseoin mentioned this issue Nov 15, 2023
Merged
6 tasks
@oseoin oseoin linked a pull request Nov 15, 2023 that will close this issue
Add initContainerResources Helm configuration #4651
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oseoin oseoin

Labels
backlog Pull requests/issues that are backlog items help wanted Issues identified as good community contribution opportunities proposal An issue that proposes a feature request
Projects
NGINX Ingress Controller
Archived in project
Milestone
v3.4.0
Development

Successfully merging a pull request may close this issue.

Add initContainerResources Helm configuration nginxinc/kubernetes-ingress
6 participants
@bj0rn @brianehlert @oseoin @jasonwilliams14 @vepatel @danielnginx