-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initContainerResources Helm configuration #4651
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4651 +/- ##
=======================================
Coverage 51.96% 51.96%
=======================================
Files 59 59
Lines 16972 16972
=======================================
Hits 8820 8820
Misses 7857 7857
Partials 295 295 ☔ View full report in Codecov by Sentry. |
…om:nginxinc/kubernetes-ingress into 3804-requests-and-limits-on-init-container
vepatel
reviewed
Nov 16, 2023
docs/content/installation/installing-nic/installation-with-helm.md
Outdated
Show resolved
Hide resolved
Signed-off-by: oseoin <oseoin@users.noreply.github.com>
jjngx
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
shaun-nx
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
helm_chart
Pull requests that update the Helm Chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue: 3804
This adds a new ResourceRequirements value which can be used for setting the resource requests/limits on the init container which is used for populating the
emptyDir
mounts used for writing whenreadOnlyRootFilesystem
is set totrue
.Defaults:
Example override:
Checklist
Before creating a PR, run through this checklist and mark each as complete.