Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initContainerResources Helm configuration #4651

Merged
merged 9 commits into from
Nov 20, 2023

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Nov 15, 2023

Proposed changes

Issue: 3804

This adds a new ResourceRequirements value which can be used for setting the resource requests/limits on the init container which is used for populating the emptyDir mounts used for writing when readOnlyRootFilesystem is set to true.

Defaults:

  ## The resources for the Ingress Controller init container which is used when readOnlyRootFilesystem is set to true.
  initContainerResources:
    requests:
      cpu: 100m
      memory: 128Mi
    # limits:
    #   cpu: 1
    #   memory: 1Gi

Example override:

  initContainerResources:
    requests:
      cpu: 50m
      memory: 32Mi
    limits:
      cpu: 50m
      memory: 64Mi

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin linked an issue Nov 15, 2023 that may be closed by this pull request
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d85f27) 51.96% compared to head (9857943) 51.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4651   +/-   ##
=======================================
  Coverage   51.96%   51.96%           
=======================================
  Files          59       59           
  Lines       16972    16972           
=======================================
  Hits         8820     8820           
  Misses       7857     7857           
  Partials      295      295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oseoin oseoin marked this pull request as ready for review November 15, 2023 14:49
@oseoin oseoin requested review from a team as code owners November 15, 2023 14:49
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@oseoin oseoin merged commit 7fcee3d into main Nov 20, 2023
62 checks passed
@oseoin oseoin deleted the 3804-requests-and-limits-on-init-container branch November 20, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Helm chart: requests and limits on init container
4 participants