Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Tests in Kind fails due to incorrect Dockerfile path in the tests directory #4625

Closed
oseoin opened this issue Nov 8, 2023 · 1 comment · Fixed by #4631
Closed
Assignees
Labels
backlog Pull requests/issues that are backlog items

Comments

@oseoin
Copy link
Contributor

oseoin commented Nov 8, 2023

Describe the bug
When following the instructions in Running Tests in Kind the process fails due to two incorrect references to the Dockerfile.

➜  make build
docker build -t test-runner:latest -f docker/Dockerfile ..
[+] Building 0.0s (0/0)   docker:desktop-linux
ERROR: could not find docker: stat docker: no such file or directory
make: *** [build] Error 1
➜  make create-kind-cluster
/bin/bash: docker/Dockerfile: No such file or directory
kind create cluster --image  --config=<(sed 's/dual/dual/' ./ci-files/ci-kind-config.yaml)
ERROR: failed to create cluster: node(s) already exist for a cluster with the name "kind"
make: *** [create-kind-cluster] Error 1

To Reproduce
Steps to reproduce the behavior:

  1. cd to the tests directory
  2. Following the instructions, run make build and make create-kind-cluster
  3. See error

Expected behavior
Test runner container image is built and kind cluster is initialised.

Your environment

Additional context
Removing the docker/ in both references seems to resolve the issue, I'll open a PR.

Copy link

github-actions bot commented Nov 8, 2023

Hi @oseoin thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@shaun-nx shaun-nx added the backlog Pull requests/issues that are backlog items label Nov 8, 2023
@oseoin oseoin self-assigned this Nov 8, 2023
@oseoin oseoin linked a pull request Nov 9, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants