Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile references to tests/Dockerfile #4631

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Update Makefile references to tests/Dockerfile #4631

merged 2 commits into from
Nov 9, 2023

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Nov 9, 2023

Proposed changes

Change tests/Makefile local references of tests/Dockerfile from docker/Dockerfile to Dockerfile.

Related issue: 4625

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin requested a review from a team as a code owner November 9, 2023 09:52
@oseoin oseoin linked an issue Nov 9, 2023 that may be closed by this pull request
Running Tests in Kind fails due to incorrect Dockerfile path in the tests directory #4625
Closed
@github-actions github-actions bot added the tests Pull requests that update tests label Nov 9, 2023
jjngx
jjngx approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jjngx jjngx requested a review from a team November 9, 2023 09:55
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #4631 (71a337a) into main (0e1e647) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4631   +/-   ##
=======================================
  Coverage   51.99%   51.99%           
=======================================
  Files          59       59           
  Lines       16960    16960           
=======================================
  Hits         8818     8818           
  Misses       7847     7847           
  Partials      295      295

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

shaun-nx
shaun-nx approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oseoin oseoin merged commit 2816996 into main Nov 9, 2023
62 checks passed
@oseoin oseoin deleted the 4625-running-tests-in-kind-fails-due-to-incorrect-dockerfile-path-in-the-tests-directory branch November 9, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running Tests in Kind fails due to incorrect Dockerfile path in the tests directory
3 participants
@oseoin @jjngx @shaun-nx