Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong default value for main-template-path and virtualserver-template-path flag in the docs #4679

Closed
haywoodsh opened this issue Nov 20, 2023 · 2 comments · Fixed by #4698
Closed

Wrong default value for main-template-path and virtualserver-template-path flag in the docs #4679

haywoodsh opened this issue Nov 20, 2023 · 2 comments · Fixed by #4698
Labels
backlog Pull requests/issues that are backlog items bug An issue reporting a potential bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities

Comments

@haywoodsh
Copy link
Contributor

haywoodsh commented Nov 20, 2023 •
edited

Describe the bug
Wrong default value in the docs

The correct paths should be "nginx.tmpl" and "nginx-plus.tmpl" as used in the codebase

To Reproduce
Steps to reproduce the behavior:

  1. Deploy x to '...' using some.yaml
  2. View logs on '....'
  3. See error

Expected behavior
A clear and concise description of what you expected to happen.

Your environment

  • Version of the Ingress Controller - release version or a specific commit
  • Version of Kubernetes
  • Kubernetes platform (e.g. Mini-kube or GCP)
  • Using NGINX or NGINX Plus

Additional context
Add any other context about the problem here. Any log files you want to share.
@github-actions GitHub Actions
Copy link

Hi @haywoodsh thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@haywoodsh haywoodsh changed the title Wrong default value for main-template-path flag in the docs Wrong default value for main-template-path and virtualserver-template-path flag in the docs Nov 20, 2023
@haywoodsh haywoodsh added bug An issue reporting a potential bug backlog Pull requests/issues that are backlog items good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Nov 20, 2023
@opencmit2
Copy link
Contributor

Hi @haywoodsh
Please assign it to me, I will take care of it.

opencmit2 added a commit to opencmit2/kubernetes-ingress that referenced this issue Nov 23, 2023
@opencmit2
Fix issue [nginxinc#4679]: Incorrect default value for main-template-…
ef9eda6 
…path and virtualserver-template-path flags

Signed-off-by: JustinWang <opencmit2@126.com>
@opencmit2 opencmit2 mentioned this issue Nov 23, 2023
Merged
6 tasks
jjngx pushed a commit that referenced this issue Nov 27, 2023
@opencmit2
Fix issue [#4679]: Incorrect default value for main-template-path and… (
4dc2d33 
#4698)
@haywoodsh haywoodsh linked a pull request Nov 28, 2023 that will close this issue
Fix issue [#4679]: Incorrect default value for main-template-path and… #4698
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Pull requests/issues that are backlog items bug An issue reporting a potential bug good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
2 participants
@haywoodsh @opencmit2