Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weight changes dynamic reload invalid status #5319

Closed
2 tasks
j1m-ryan opened this issue Mar 27, 2024 · 2 comments · Fixed by #5375
Closed
2 tasks

Fix weight changes dynamic reload invalid status #5319

j1m-ryan opened this issue Mar 27, 2024 · 2 comments · Fixed by #5375
Assignees
@j1m-ryan
Labels
backlog Pull requests/issues that are backlog items bug An issue reporting a potential bug

Comments

@j1m-ryan
Copy link
Member

j1m-ryan commented Mar 27, 2024 •
edited
Loading

When using weight change dynamic reloads:

  • A VS or VSR updated with incorrect weights is marked invalid (currently this is warning for VSR when using weight change dynamic reloads)
  • A VS or VSR with incorrect weights, (and, i.e in an invalid state), should not be able to take traffic
@j1m-ryan j1m-ryan self-assigned this Mar 27, 2024
@vepatel vepatel added backlog Pull requests/issues that are backlog items bug An issue reporting a potential bug labels Apr 8, 2024
@brianehlert
Copy link
Collaborator

Wasn't there a PR to address this?

@j1m-ryan
Copy link
Member Author

j1m-ryan commented Apr 9, 2024

No, not yet

@j1m-ryan j1m-ryan mentioned this issue Apr 11, 2024
Merged
6 tasks
@j1m-ryan j1m-ryan changed the title Look into weight changes dynamic reload invalid status Fix weight changes dynamic reload invalid status Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j1m-ryan j1m-ryan

Labels
backlog Pull requests/issues that are backlog items bug An issue reporting a potential bug
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix status for invalid vs and vsr, for weight changes dynamic reload nginxinc/kubernetes-ingress
3 participants
@brianehlert @j1m-ryan @vepatel