Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix status for invalid vs and vsr, for weight changes dynamic reload #5375

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

j1m-ryan
Copy link
Member

Proposed changes

Resolves #5319
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner April 11, 2024 12:30
@github-actions github-actions bot added the bug An issue reporting a potential bug label Apr 11, 2024
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@j1m-ryan j1m-ryan enabled auto-merge (squash) April 12, 2024 09:25
@j1m-ryan j1m-ryan merged commit 1c6a074 into main Apr 12, 2024
49 of 50 checks passed
@j1m-ryan j1m-ryan deleted the fix/dynamic-weight-change-invalid-status branch April 12, 2024 09:48
j1m-ryan added a commit that referenced this pull request Apr 29, 2024
…amic reload … (#5464)

fix status for invalid vs and vsr, for weight changes dynamic reload (#5375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix weight changes dynamic reload invalid status
3 participants