Make installing CRDs via kubectl a prerequisite for helm2 clients #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
@Dean-Coakley looks good!
Please implement a suggestion before merging.
lucacome
approved these changes
Jul 10, 2020
Installing CRDs is now a prerequisite to installing the chart via helm2 clients. Also included general docs structure improvements.
Dean-Coakley
force-pushed
the
helm2-crd-fix
branch
from
5495145
to
fb3a8fa
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
crd-installhooks have been removed.Checklist
Before creating a PR, run through this checklist and mark each as complete.