Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require secrets to have types #1225

Merged
merged 5 commits into from
Nov 18, 2020
Merged

Require secrets to have types #1225

merged 5 commits into from
Nov 18, 2020

Conversation

pleshakov
Copy link
Contributor

Proposed changes

This PR introduces secret types that the Ingress Controller can support:

  • kubernetes.io/tls for TLS secrets. Such secrets must have the tls.crt and tls.key keys.
  • nginx.org/ca - for CA secrets. Such secrets must have the ca.crt key with a CA.
  • nginx.org/jwk - for JWK secrets. Such secrets must include the jwk key with a JWK.

The Ingress Controller will no longer support secrets without the type field set to the types above.

@pleshakov pleshakov added enhancement Pull requests for new features/feature enhancements change Pull requests that introduce a change labels Nov 14, 2020
Copy link

@mikestephen mikestephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@pleshakov pleshakov merged commit ed58ce1 into master Nov 18, 2020
@pleshakov pleshakov deleted the process-secrets-1 branch November 18, 2020 22:00
@pleshakov pleshakov changed the title Introduce secret types Require secrets to have types Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Pull requests that introduce a change enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants