Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate policy resource and accessControl policy to GA #1290

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Graduate policy resource and accessControl policy to GA #1290

merged 3 commits into from
Jan 6, 2021

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

  • Update policy resource apiVersion v1alpha1 -> v1
  • Update accessControl apiVersion v1alpha1 -> v1
  • Update documentation to reflect policy and accessControl graduation to GA.
  • Fix integration tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley self-assigned this Dec 17, 2020
@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Dec 17, 2020
@Dean-Coakley Dean-Coakley requested review from pleshakov and lucacome and removed request for pleshakov December 17, 2020 17:31
pleshakov
pleshakov approved these changes Dec 17, 2020
View reviewed changes
pkg/apis/configuration/v1/types.go Outdated Show resolved Hide resolved
@Dean-Coakley Dean-Coakley force-pushed the graduate-policy-res branch 2 times, most recently from 885b9dc to c7253da Compare December 18, 2020 11:41
@Dean-Coakley Dean-Coakley marked this pull request as draft December 18, 2020 18:00
@Dean-Coakley Dean-Coakley marked this pull request as ready for review January 4, 2021 17:13
@Dean-Coakley Dean-Coakley force-pushed the graduate-policy-res branch 2 times, most recently from e577318 to 8ea7fc7 Compare January 4, 2021 17:47
@Dean-Coakley
Copy link
Contributor Author

Dean-Coakley commented Jan 4, 2021 •
edited
Loading

@pleshakov This is ready for review. (I'll investigate failing tests further tomorrow)

pleshakov
pleshakov approved these changes Jan 5, 2021
View reviewed changes
docs-web/installation/installation-with-helm.md Show resolved Hide resolved
docs-web/configuration/policy-resource.md Outdated Show resolved Hide resolved
@Dean-Coakley Dean-Coakley force-pushed the graduate-policy-res branch 2 times, most recently from 9e4f159 to 72ea24f Compare January 5, 2021 16:13
mikestephen
mikestephen approved these changes Jan 6, 2021
View reviewed changes
Copy link

@mikestephen mikestephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good Dean!

@Dean-Coakley Dean-Coakley merged commit d652a42 into master Jan 6, 2021
@Dean-Coakley Dean-Coakley deleted the graduate-policy-res branch January 6, 2021 13:08
@vepatel vepatel mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikestephen mikestephen mikestephen approved these changes

@pleshakov pleshakov pleshakov approved these changes

@lucacome lucacome Awaiting requested review from lucacome

Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @mikestephen @pleshakov