Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub action fixes #1429

Merged
merged 2 commits into from
Mar 5, 2021
Merged

GitHub action fixes #1429

merged 2 commits into from
Mar 5, 2021

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Mar 4, 2021

  • Use Ubuntu 20.04 everywhere in GitHub actions
  • Add commit variable to release images

@lucacome lucacome requested review from ciarams87 and a team March 4, 2021 22:18
@lucacome lucacome self-assigned this Mar 4, 2021
@lucacome lucacome requested review from LorcanMcVeigh and soneillf5 and removed request for a team March 4, 2021 22:18
@github-actions github-actions bot added bug An issue reporting a potential bug chore Pull requests for routine tasks labels Mar 4, 2021
soneillf5
soneillf5 approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@soneillf5 soneillf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@lucacome lucacome merged commit d146cb3 into master Mar 5, 2021
@lucacome lucacome deleted the chore/ci branch March 5, 2021 17:10
@lucacome lucacome changed the title Github action fixes GitHub action fixes Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@soneillf5 soneillf5 soneillf5 approved these changes

@LorcanMcVeigh LorcanMcVeigh Awaiting requested review from LorcanMcVeigh

Assignees

@lucacome lucacome

Labels
bug An issue reporting a potential bug chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @ciarams87 @soneillf5