Wait for caches to sync when the Ingress Controller starts #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soneillf5
approved these changes
Mar 15, 2021
pleshakov
force-pushed
the
fix-readiness-check-2
branch
3 times, most recently
from
db092f0
to
663176e
Compare
vepatel
reviewed
Mar 16, 2021
| vs_crd_name = get_name_from_yaml(f"{DEPLOYMENTS}/common/crds-v1beta1/k8s.nginx.org_virtualservers.yaml") | ||
| vsr_crd_name = get_name_from_yaml(f"{DEPLOYMENTS}/common/crds-v1beta1/k8s.nginx.org_virtualserverroutes.yaml") | ||
| pol_crd_name = get_name_from_yaml(f"{DEPLOYMENTS}/common/crds-v1beta1/k8s.nginx.org_policies.yaml") | ||
| ts_crd_name = get_name_from_yaml(f"{DEPLOYMENTS}/common/crds-v1beta1/k8s.nginx.org_transportservers.yaml") |
There was a problem hiding this comment.
do we need ts crd in AP or is it mandatory now to have all crds?
There was a problem hiding this comment.
whenever -enable-custom-resources is set to true, it is necessary to register all custom resources CRDs. otherwise, the informers will not sync, and the IC will not become ready
lucacome
approved these changes
Mar 16, 2021
vepatel
approved these changes
Mar 16, 2021
Because of the changes in 70e6b8c, the Ingress Controller will not become ready until all informers are synced. An informer for a CR will not sync until the corresponding CRD exists in the cluster. This commit ensures that all required CRDs are created prior to deploying the IC, so that CR informers can sync.
pleshakov
force-pushed
the
fix-readiness-check-2
branch
from
7ed7f7c
to
e5208d5
Compare
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When the Ingress Controller is ready, its readiness probe succeeds, and it starts accepting client traffic.
The IC becomes ready when it drains the work queue at the start - this means the IC generated the configuration for all Ingress and other relevant resources in the cluster.
However, because the IC didn't wait for the caches to sync before starting processing the work queue, the work queue could contain only a fraction of the resources in the cluster. As a result, the IC would drain the queue quickly and mistakenly become ready. This is a bug, as not every relevant resource was processed.
Now, before starting the work queue, the IC waits for the caches to sync. This fixes the problem
Changes: