Add max connections to TransportServer #1480
Conversation
github-actions
bot
added
the
documentation
soneillf5
force-pushed
the
feature-max-connections-transportserver-upstream-server
branch
from
3ed67a3
to
8c08880
Compare
soneillf5
requested review from
vepatel
and removed request for
ciarams87 and
lucacome
| * Build the docker image with an increased version number ```docker build -t tcp-server:v2``` | ||
| * Push the docker image to the public repo | ||
| * Build the docker image with an increased version number ```docker build -t tcp-server:2.1``` | ||
| * Push the docker image to the public repo ```docker push seanoneillf5/tcp-server:2.1``` |
There was a problem hiding this comment.
should we not specify the exact repo name and replace it with <public_repo_name> as user will be creating their own?
There was a problem hiding this comment.
Perhaps we can create a team/company repo?
cc @ciarams87
There was a problem hiding this comment.
Hi @soneillf5
The PR looks good to me, expect for the name of the field.
Could we use maxConns as the name of the field? There are two reasons:
(1) With new resources - Policies and TransportServer - we started using camelCase for field names. However, we still want to be consistent with the VS/VSR resources. For max conns, VS/VSR upstreams have max-conns field. This is similar to how NGINX uses the same directive and parameters in HTTP and TCP configuration.
(2) For fields related to parameters and tunables (for example, load balancing parameters, rate-limiting parameters, etc.), we reuse NGINX nomenclature. For example, the existing maxFails, failTimeout in TransportServer.
| * Build the docker image with an increased version number ```docker build -t tcp-server:v2``` | ||
| * Push the docker image to the public repo | ||
| * Build the docker image with an increased version number ```docker build -t tcp-server:2.1``` | ||
| * Push the docker image to the public repo ```docker push seanoneillf5/tcp-server:2.1``` |
There was a problem hiding this comment.
Perhaps we can create a team/company repo?
cc @ciarams87
|
@pleshakov I've updated it to 'maxConns'. I think it's better not to, but since you've blocked the PR, I've made the change. |
soneillf5
force-pushed
the
feature-max-connections-transportserver-upstream-server
branch
from
6577a86
to
f54e24c
Compare
soneillf5
force-pushed
the
feature-max-connections-transportserver-upstream-server
branch
from
f54e24c
to
36fabaf
Compare
lucacome
deleted the
feature-max-connections-transportserver-upstream-server
branch
pleshakov
changed the title
Proposed changes
This change allows users to specify the max number of connections to the proxied server. https://nginx.org/en/docs/stream/ngx_stream_upstream_module.html#max_conns
Checklist
Before creating a PR, run through this checklist and mark each as complete.