Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Auto sync crds #1487

Merged
merged 2 commits into from
Mar 30, 2021
Merged

chore: Auto sync crds #1487

merged 2 commits into from
Mar 30, 2021

Conversation

ciarams87
Copy link
Member

Proposed changes

This commit updates the sync workflow to also sync the CRDs (deployments/common/crds/*) to the nginx-ingress-operator.
This sync will open a PR in the destination repo - see nginxinc/nginx-ingress-operator#86 for an example.

It also consolidates the existing sync-labels workflow and the sync workflow to one file and adds comments to describe what each job is doing.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@ciarams87 ciarams87 added chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code labels Mar 30, 2021
@ciarams87 ciarams87 self-assigned this Mar 30, 2021
@ciarams87 ciarams87 merged commit 3861a5a into master Mar 30, 2021
@ciarams87 ciarams87 deleted the auto-sync-crds branch March 30, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants