Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NGINX_VERSION from base images #1503

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Apr 3, 2021

  • Let dependabot find new updates for base images.
  • NGINX_VERSION is set in the base images, so it can be used where needed

@lucacome lucacome requested review from a team, ciarams87 and soneillf5 and removed request for a team April 3, 2021 00:11
@lucacome lucacome self-assigned this Apr 3, 2021
@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 3, 2021
ARG IC_VERSION

ENV NGINX_VERSION 1.19.9
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the base image for openshift is not specific for NGINX and doesn't have the variable so we need to set it manually for now.

Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@lucacome lucacome force-pushed the chore/remove-nginx-var-from-base branch from d701ab8 to 227a486 Compare April 6, 2021 17:38
@lucacome lucacome force-pushed the chore/remove-nginx-var-from-base branch from 227a486 to a75d592 Compare April 6, 2021 17:47
@lucacome lucacome merged commit bf41215 into master Apr 6, 2021
@lucacome lucacome deleted the chore/remove-nginx-var-from-base branch April 6, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants