Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature transport server status tests #1516

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Feature transport server status tests #1516

merged 1 commit into from
Apr 9, 2021

Conversation

soneillf5
Copy link
Contributor

@soneillf5 soneillf5 commented Apr 6, 2021 •
edited
Loading

Proposed changes

Add tests for TransportServer status functionality.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 6, 2021
@soneillf5 soneillf5 force-pushed the feature-transport-server-status-tests branch from 85c5437 to 9fc2a04 Compare April 7, 2021 09:18
@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Apr 7, 2021
pleshakov
pleshakov reviewed Apr 7, 2021
View reviewed changes
tests/suite/test_transport_server_status.py Show resolved Hide resolved
tests/suite/test_transport_server_status.py Outdated Show resolved Hide resolved
tests/suite/fixtures.py Outdated Show resolved Hide resolved
tests/suite/fixtures.py Show resolved Hide resolved
tests/suite/fixtures.py Outdated Show resolved Hide resolved
tests/data/transport-server-status/rejected-warning.yaml Show resolved Hide resolved
tests/suite/test_transport_server_status.py Show resolved Hide resolved
@soneillf5 soneillf5 force-pushed the feature-transport-server-status-tests branch from 7155185 to 9ab98d3 Compare April 8, 2021 11:11
vepatel
vepatel approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@vepatel vepatel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soneillf5 lgtm, just a few suggestions related to definition names in comments if you can take a look.

@soneillf5 soneillf5 force-pushed the feature-transport-server-status-tests branch from cb6f1e5 to fd0c6dc Compare April 9, 2021 09:34
@soneillf5 soneillf5 merged commit 082d957 into master Apr 9, 2021
@soneillf5 soneillf5 deleted the feature-transport-server-status-tests branch April 9, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@vepatel vepatel vepatel approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87

@lucacome lucacome Awaiting requested review from lucacome

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soneillf5 @pleshakov @vepatel