Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ensure connections #1539

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Fix ensure connections #1539

merged 2 commits into from
Apr 20, 2021

Conversation

pleshakov
Copy link
Contributor

Proposed changes

  • Add timeout for establishing a connection to prevent potential
    "hangs" of the test runs. The problem was noticeable when running
    tests in kind.
  • Increase the number of tries to make sure the Ingress Controller
    pod has enough time to get ready. When running tests in kind
    locally the number of tries sometimes was not enough.
  • Ensure connection to NGINX before running tests.
    Without ensuring, sometimes the first connection to NGINX would
    hang (timeout). The problem is noticeable when running tests in
    kind.

* Add timeout for establishing a connection to prevent potential
"hangs" of the test runs. The problem was noticeable when running
tests in kind.
* Increase the number of tries to make sure the Ingress Controller
pod has enough time to get ready. When running tests in kind
locally the number of tries sometimes was not enough.
Ensure connection to NGINX before running tests.
Without ensuring, sometimes the first connection to NGINX would
hang (timeout). The problem is noticable when running tests in
kind.
@pleshakov pleshakov added the python Pull requests that update Python code label Apr 16, 2021
@github-actions github-actions bot added the bug An issue reporting a potential bug label Apr 16, 2021
@pleshakov pleshakov removed the bug An issue reporting a potential bug label Apr 20, 2021
@pleshakov pleshakov merged commit 78bd423 into master Apr 20, 2021
@pleshakov pleshakov deleted the fix-ensure-connections branch April 20, 2021 15:53
@lucacome lucacome added the chore Pull requests for routine tasks label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants