Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing njs module to the openshift-image-nap-plus image #1658

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

ciarams87
Copy link
Member

Proposed changes

If -enable-preview-policies is set, the nginx-plus-module-njs module is required on plus images. The NAP UBI image does not currently have this installed - this commit adds the required package.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@ciarams87 ciarams87 merged commit b37389d into master Jun 11, 2021
@ciarams87 ciarams87 deleted the bug/install-njs-module-nap-ubi branch June 11, 2021 09:16
@ciarams87 ciarams87 added the bug An issue reporting a potential bug label Jun 16, 2021
@pleshakov pleshakov changed the title bug: add njs plus module to nap ubi image Add missing njs module to the openshift-image-nap-plus image Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants