Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest Docker image for golangci-lint #1686

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Use latest Docker image for golangci-lint #1686

merged 1 commit into from
Jun 23, 2021

Conversation

lucacome
Copy link
Member

After some thought (and finding a fast way to use the docker container), I don't think we need to pin the version of golangci-lint, we can just use the latest version available, what do you think?

@lucacome lucacome requested a review from a team June 21, 2021 20:31
@lucacome lucacome self-assigned this Jun 21, 2021
@lucacome lucacome requested review from pleshakov and ciarams87 and removed request for a team June 21, 2021 20:31
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jun 21, 2021
@pleshakov
Copy link
Contributor

After some thought (and finding a fast way to use the docker container), I don't think we need to pin the version of golangci-lint, we can just use the latest version available, what do you think?

does it mean we will have a mismatch between the version here and here https://github.com/nginxinc/kubernetes-ingress/blob/master/.github/workflows/lint.yml#L34 ? can this create problems? like the linting succeeds locally but fails on GitHub or vice-versa.

@lucacome
Copy link
Member Author

does it mean we will have a mismatch between the version here and here https://github.com/nginxinc/kubernetes-ingress/blob/master/.github/workflows/lint.yml#L34 ?

@pleshakov no that action will use the latest binary available if it can't find a "pin" anywhere. Now it's using the version that we have in go.mod. With the change in this PR everything will use "latest".

@lucacome lucacome enabled auto-merge (squash) June 23, 2021 00:27
@lucacome lucacome requested a review from soneillf5 June 23, 2021 14:56
@lucacome lucacome merged commit 181e18a into master Jun 23, 2021
@lucacome lucacome deleted the deps/remove-golangci branch June 23, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@soneillf5 soneillf5 soneillf5 approved these changes

@ciarams87 ciarams87 Awaiting requested review from ciarams87

Assignees

@lucacome lucacome

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @pleshakov @soneillf5