Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the release scripts in the hack folder #1769

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

ciarams87
Copy link
Member

Proposed changes

This commit updates the scripts we use to prepare the release commits.

  • Because we no longer update the files separately in the master branch (we merge the release branch into master), we no longer need a separate file to prepare that commit.
  • The files can be updated for a major release using hack/prepare-major-release.sh prev_ic_version ic-version prev_helm_chart_version helm-chart-version. The docs/content/releases.md file will still need to be updated manually.
  • The files for a minor release can be updated as before using hack/prepare-minor-release.sh ic-version helm-chart-version. The changelog template has been updated for the new docs format.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 20, 2021
@ciarams87 ciarams87 force-pushed the chore/update-hack-release-files branch from 7afe82e to 5d109e9 Compare July 20, 2021 13:47
hack/common-release-prep.sh Outdated Show resolved Hide resolved
@ciarams87 ciarams87 force-pushed the chore/update-hack-release-files branch from 5d109e9 to 4f1470e Compare July 21, 2021 07:16
@ciarams87 ciarams87 merged commit 169ad9d into master Jul 21, 2021
@ciarams87 ciarams87 deleted the chore/update-hack-release-files branch July 21, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants