Reload only once during the start #1788
Merged
+266
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
added
the
enhancement
vepatel
reviewed
Aug 3, 2021
tests/suite/test_smoke.py
Outdated
| class TestSmoke: | ||
| @pytest.mark.ingresses |
There was a problem hiding this comment.
ingresses marker and ingress_controller fixture can and should be called at class level as ic one is common to both tests and ingresses marker will only cause first test to run in its current form
soneillf5
reviewed
Aug 9, 2021
soneillf5
approved these changes
Aug 10, 2021
During the start, the IC processes resources in the cluster one by one Each processing might lead to a new generated config or an updated config, which requires an NGINX reload. After all resources are processed, the IC pod is considered Ready (its readiness probe succeeds). For clusters with big number of resources the combined time of NGINX reloads during the start can be significant (minutes). This commit ensures that the IC only reloads NGINX once during the start, which reduces the start up time for clusters with big number of resources.
pleshakov
force-pushed
the
fix/startup-time
branch
from
749edec
to
5bfb7a6
Compare
lucacome
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
During the start, the IC processes resources in the cluster one by one
Each processing might lead to a new generated config or an updated config,
which requires an NGINX reload. After all resources are processed,
the IC pod is considered Ready (its readiness probe succeeds).
For clusters with big number of resources the combined time
of NGINX reloads during the start can be significant (minutes).
This PR ensures that the IC only reloads NGINX once during
the start, which reduces the start up time for clusters
with big number of resources.
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Fixes #1655