Update docs and examples to use networking.k8s.io/v1 #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
requested review from
ciarams87 and
soneillf5
and removed request for
a team
github-actions
bot
added
chore
tomasohaodha
suggested changes
Aug 12, 2021
lucacome
force-pushed
the
chore/update-docs-examples-v1
branch
from
3be1825
to
5680254
Compare
lucacome
force-pushed
the
chore/update-docs-examples-v1
branch
from
9d74294
to
d74f6f1
Compare
pleshakov
approved these changes
Aug 12, 2021
| service: | ||
| name: tea-svc | ||
| port: | ||
| number: 80 | ||
| - path: /coffee | ||
| pathType: ImplementationSpecific # default |
There was a problem hiding this comment.
it is mandatory, not default in v1, right? shall we remove the default comment?
I think we need to rewrite this doc a bit and merge New Features Available in Kubernetes 1.18 and Above into the rest of the doc, because with NIC 1.13, there will be only v1. I will create a PR for that
lucacome
commented
Aug 12, 2021
docs/content/configuration/ingress-resources/basic-configuration.md
Outdated
Show resolved
Hide resolved
ciarams87
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
networking.k8s.io/v11.22.0