Fix increased IC pod startup time when hundreds VirtualServerRoutes are used #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
commented
Sep 2, 2021
| VSR_COUNT=500 | ||
|
|
||
| @pytest.fixture(scope="class") | ||
| def vs_vsr_setup( |
There was a problem hiding this comment.
this function doesn't remove any created resources because k8s will remove them when the test_namespace is deleted.
There was a problem hiding this comment.
test_namespace fixture is class scoped not method so if there are other tests in same class then those resources will remain until all the tests are executed.
| and get_last_reload_status(metrics_url, "nginx") == "1" | ||
| ) | ||
|
|
||
| assert num is None |
There was a problem hiding this comment.
I took this assert from the other tests - not fully sure though about it
There was a problem hiding this comment.
this is to make sure that it scaled down to 0 before starting to scale up but not necessary anymore since we've better checks now.
vepatel
reviewed
Sep 7, 2021
vepatel
reviewed
Sep 7, 2021
vepatel
requested changes
Sep 7, 2021
vepatel
approved these changes
Sep 7, 2021
soneillf5
approved these changes
Sep 7, 2021
Previously, the IC would update the status of a VSR (via an API call to the k8s API) even if the status of the VSR wasn't changed. The unnecessary API calls lead to the increased IC pod startup time for cases when a VS had multiple (hundreds) VSRs. The commit fixes the problem - the IC will skip the update if the status of a VSR isn't changed.
pleshakov
force-pushed
the
fix/vsr-status
branch
from
1601542
to
3a41c8a
Compare
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, the IC would update the status of a VSR (via an API call to the k8s API) even if the status of the VSR wasn't changed. The unnecessary API calls lead to the increased IC pod startup time for cases when a VS had multiple (hundreds) VSRs.
The PR fixes the problem - the IC will skip the update if the status of a VSR isn't changed.
The PR includes a test that creates a VS with multiple VSRs and then checks the startup time of the pod.
The output is for 500 VSRs:
Before: gave up after 15 mins
Now: 201 seconds