Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function name comments typo #1927

Merged
merged 6 commits into from
Sep 8, 2021
Merged

Fix function name comments typo #1927

merged 6 commits into from
Sep 8, 2021

Conversation

snebel29
Copy link
Contributor

@snebel29 snebel29 commented Sep 3, 2021

Proposed changes

I was reading the code and noticed small typo in some of the un-exported functions in internal/k8s/controller.go.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@ciarams87 ciarams87 enabled auto-merge (squash) September 8, 2021 15:04
@ciarams87 ciarams87 merged commit 85ce9d0 into nginxinc:master Sep 8, 2021
@lucacome lucacome added the documentation Pull requests/issues for documentation label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

@soneillf5 soneillf5 soneillf5 approved these changes

@lucacome lucacome Awaiting requested review from lucacome

@ciarams87 ciarams87 Awaiting requested review from ciarams87

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@snebel29 @pleshakov @soneillf5 @lucacome @ciarams87