Increase default upstream zone size for NGINX Plus #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
pleshakov
force-pushed
the
change/increase-zone-size
branch
from
d326cb2
to
1599a97
Compare
pleshakov
changed the title
ciarams87
reviewed
Sep 27, 2021
| @@ -318,7 +322,7 @@ def test_upstream_zone_size_0(self, cli_arguments, kube_apis, | |||
| if cli_arguments["ic-type"] == "nginx-plus-ingress": | |||
| print("Run assertions for Nginx Plus case") | |||
| assert "zone " in result_conf | |||
| assert " 256k;" in result_conf | |||
| assert " 512k;" in result_conf | |||
There was a problem hiding this comment.
This is causing failures in the pipeline, although for some reason it is not showing up in the PR: https://gitlab.com/f5/nginx/kic/kubernetes-ingress/-/jobs/1623726013
There was a problem hiding this comment.
thanks for pointing out. forgot to update the template for N+ for Ingress, it still uses 256k default:
zone {{$upstream.Name}} {{if ne $upstream.UpstreamZoneSize "0"}}{{$upstream.UpstreamZoneSize}}{{else}}256k{{end}};
NGINX Plus R25 allocates more memory for storing upstream server (peer) data: +720 bytes per peer. This means upstream server zones will use more memory to accommodate that data. If a zone is full, NGINX Plus will fail to reload and fail to add more upstream servers via the API. To prevent reload failures after an upgrade to R25, this commit increases the default upstream zone size for NGINX Plus from 256K to 512K.
pleshakov
force-pushed
the
change/increase-zone-size
branch
from
5628bd1
to
1a44c5a
Compare
lucacome
approved these changes
Sep 27, 2021
ciarams87
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
NGINX Plus R25 allocates more memory for storing upstream server (peer) data: +720 bytes per peer. This means upstream server zones will use more memory to accommodate that data.
If a zone is full, NGINX Plus will fail to reload and fail to add more upstream servers via the API.
To prevent reload failures after an upgrade to R25, this commit increases the default upstream zone size for NGINX Plus from 256K to 512K.