Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable setting mandatory and persistent in upstream healthchecks in VS and VSR #2251

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

ciarams87
Copy link
Member

Proposed changes

See mandatory-health-checks

The mandatory parameter requires every newly added server to pass all configured health checks before NGINX Plus sends traffic to it. When combined with slow start, it gives a new server more time to connect to databases and “warm up” before being asked to handle their full share of traffic. Mandatory health checks can be marked as persistent, so that the previous state is remembered when reloading configuration.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Dec 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #2251 (0655f94) into master (98239fc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0655f94 differs from pull request most recent head 9b6e8c3. Consider uploading reports for the commit 9b6e8c3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2251   +/-   ##
=======================================
  Coverage   53.41%   53.42%           
=======================================
  Files          43       43           
  Lines       13412    13419    +7     
=======================================
+ Hits         7164     7169    +5     
  Misses       6020     6020           
- Partials      228      230    +2     
Impacted Files Coverage Δ
internal/configs/version2/http.go 0.00% <ø> (ø)
internal/configs/virtualserver.go 95.22% <100.00%> (+0.01%) ⬆️
pkg/apis/configuration/validation/virtualserver.go 96.29% <100.00%> (+0.01%) ⬆️
internal/k8s/configuration.go 95.65% <0.00%> (-0.39%) ⬇️
...ternal/k8s/appprotect/app_protect_configuration.go 86.74% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98239fc...9b6e8c3. Read the comment docs.

@ciarams87 ciarams87 force-pushed the feat/add-persistent-healh-check branch from d9c0e2b to 0b72171 Compare December 7, 2021 15:39
@nginx-bot nginx-bot force-pushed the feat/add-persistent-healh-check branch 9 times, most recently from b5c49f3 to c502a1c Compare December 13, 2021 18:37
@nginx-bot nginx-bot force-pushed the feat/add-persistent-healh-check branch 8 times, most recently from 2d2b0c2 to 0655f94 Compare December 16, 2021 14:25
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 (with some doc related suggestions)

@ciarams87 ciarams87 force-pushed the feat/add-persistent-healh-check branch from 0655f94 to 9b6e8c3 Compare December 17, 2021 09:29
@soneillf5
Copy link
Contributor

@ciarams87 sorry for the late review

@ciarams87 ciarams87 force-pushed the feat/add-persistent-healh-check branch from 9b6e8c3 to 1532ee7 Compare December 17, 2021 10:44
@ciarams87 ciarams87 enabled auto-merge (squash) December 17, 2021 10:44
@ciarams87 ciarams87 merged commit 06e5d8f into master Dec 17, 2021
@ciarams87 ciarams87 deleted the feat/add-persistent-healh-check branch December 17, 2021 10:48
@pleshakov pleshakov mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants