-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docops-551 extra backslashes in KIC docs #2272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jcahilltorre
requested review from
thresheek,
jputrino,
ciarams87,
travisamartin and
ashutoshpradhan-f5
December 14, 2021 17:10
github-actions
bot
added
bug
An issue reporting a potential bug
documentation
Pull requests/issues for documentation
labels
Dec 14, 2021
ciarams87
approved these changes
Dec 15, 2021
nginx-bot
force-pushed
the
DOCOPS-551
branch
from
December 15, 2021 15:09
242efd7
to
b8bb6fc
Compare
I think one more place is missing, here's a patch to fix:
Other than that, LGTM! |
removed the extra \ reported by @thresheek via commit. Please approve. |
thresheek
approved these changes
Dec 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nginx-bot
force-pushed
the
DOCOPS-551
branch
from
December 15, 2021 17:22
021df29
to
8928e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove extra
\
appearing in two KIC documents at:https://docs.nginx.com/nginx-ingress-controller/configuration/virtualserver-and-virtualserverroute-resources/
and
https://docs.nginx.com/nginx-ingress-controller/configuration/global-configuration/configmap-resource/