refactor: use os.ReadDir for lightweight directory reading
#2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2346 +/- ##
==========================================
- Coverage 53.66% 53.65% -0.01%
==========================================
Files 48 48
Lines 14201 14203 +2
==========================================
Hits 7621 7621
- Misses 6340 6342 +2
Partials 240 240
Continue to review full report at Codecov.
|
ciarams87
reviewed
Jan 12, 2022
ciarams87
approved these changes
Jan 20, 2022
This commit also replaces the existing io/ioutil functions with their new definitions in io and os packages, since the io/ioutil package has been deprecated as of Go 1.16, see https://golang.org/doc/go1.16#ioutil. Reference: https://pkg.go.dev/io/ioutil#ReadDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
pleshakov
reviewed
Feb 5, 2022
| @@ -56,8 +58,11 @@ func getWorkerProcesses() (int, int, error) { | |||
| continue | |||
| } | |||
|
|
|||
| cmdlineFile := fmt.Sprintf("/proc/%v/cmdline", folder.Name()) | |||
| content, err := ioutil.ReadFile(cmdlineFile) | |||
| cmdlineFile := filepath.Clean(fmt.Sprintf("/proc/%v/cmdline", folder.Name())) | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
@pleshakov Hi, thanks for reviewing this PR.
filepath.Clean is necessary here to address the linting error, see this comment #2346 (comment)
pleshakov
approved these changes
Feb 7, 2022
lucacome
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: golang/go#41467
Proposed changes
os.ReadDirwas added in Go 1.16 as part of the deprecation ofioutilpackage. It is a more efficient implementation thanioutil.ReadDiras stated here https://pkg.go.dev/io/ioutil#ReadDir . The full proposal can be read here: https://github.com/golang/go/issues/41467.This PR also replaces the existing io/ioutil functions with their new definitions in io and os packages, since the io/ioutil package has been deprecated as of Go 1.16, see https://golang.org/doc/go1.16#ioutil.
Checklist
Before creating a PR, run through this checklist and mark each as complete.