Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore running nightly for Plus #2448

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Conversation

lucacome
Copy link
Member

Restores running nightly for Plus

@lucacome lucacome requested a review from a team February 24, 2022 03:04
@lucacome lucacome self-assigned this Feb 24, 2022
@lucacome lucacome requested review from ciarams87, jjngx, haywoodsh and pleshakov and removed request for a team February 24, 2022 03:04
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #2448 (579021b) into master (59b0d76) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2448   +/-   ##
=======================================
  Coverage   53.48%   53.48%           
=======================================
  Files          49       49           
  Lines       14306    14306           
=======================================
  Hits         7652     7652           
  Misses       6411     6411           
  Partials      243      243           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nightly runs never passed when we were trying to run all the tests in a single run. Until
a. we can further stabilise the tests, or
b. GitHub adds the ability to rerun a single job,
this change does not make sense.

@lucacome
Copy link
Member Author

@ciarams87 the feature is here now https://github.blog/2022-03-16-save-time-partial-re-runs-github-actions/ can we get this merged then?

@ciarams87
Copy link
Member

@ciarams87 the feature is here now https://github.blog/2022-03-16-save-time-partial-re-runs-github-actions/ can we get this merged then?

@lucacome Sorry I missed this comment in the list of emails!

They finally added the feature 🎉 ! Then yes, I see no reason not to merge this 👍🏼

@lucacome lucacome merged commit 77a2e88 into master Mar 23, 2022
@lucacome lucacome deleted the chore/restore-kind-nightly branch March 23, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants