Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .gitignore #2472

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Update .gitignore #2472

merged 1 commit into from
Mar 8, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Mar 3, 2022

Adds coverage.out to the list

@lucacome lucacome requested a review from a team March 3, 2022 19:59
@lucacome lucacome self-assigned this Mar 3, 2022
@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 3, 2022
jjngx
jjngx approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codecov-commenter
Copy link

Codecov Report

Merging #2472 (212b693) into master (51ac617) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2472      +/-   ##
==========================================
- Coverage   53.66%   53.63%   -0.03%     
==========================================
  Files          48       48              
  Lines       14200    14200              
==========================================
- Hits         7620     7616       -4     
- Misses       6342     6344       +2     
- Partials      238      240       +2
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.47% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1946a2...212b693. Read the comment docs.

@lucacome lucacome merged commit 1f2e063 into master Mar 8, 2022
@lucacome lucacome deleted the chore/update-gitignore branch March 8, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@jjngx jjngx jjngx approved these changes

@pleshakov pleshakov Awaiting requested review from pleshakov pleshakov was automatically assigned from nginxinc/kic

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx was automatically assigned from nginxinc/kic

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucacome @codecov-commenter @ciarams87 @jjngx