Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terminationGracePeriodSeconds to deployment #2637

Merged
merged 2 commits into from
May 6, 2022

Conversation

maksym-iv
Copy link
Contributor

@maksym-iv maksym-iv commented Apr 29, 2022

Proposed changes

Since terminationGracePeriodSeconds option is defined in the values.yaml and used in the daemonset resource, it makes sense to add it to the deployment resource to make this attribute customizable

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Since `terminationGracePeriodSeconds` option is defined in the `values.yaml` and used in the `daemonset` resource, it makes sense to add it to the `deployment` resource to make this attribute customizable
@lucacome lucacome self-assigned this May 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #2637 (e8f32af) into main (50a36e7) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2637      +/-   ##
==========================================
- Coverage   53.44%   53.41%   -0.03%     
==========================================
  Files          52       52              
  Lines       14702    14702              
==========================================
- Hits         7857     7853       -4     
- Misses       6585     6587       +2     
- Partials      260      262       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.47% <0.00%> (-0.39%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome added the bug An issue reporting a potential bug label May 6, 2022
@lucacome lucacome added this to the 2.3.0-k8s-ingress-controller milestone May 6, 2022
@lucacome lucacome changed the title [FIX] Add terminationGracePeriodSeconds to deployment Add terminationGracePeriodSeconds to deployment May 6, 2022
@lucacome lucacome merged commit 420aa9a into nginxinc:main May 6, 2022
@lucacome
Copy link
Member

lucacome commented May 6, 2022

Thanks for your contribution @maksym-iv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] terminationGracePeriodSeconds is missing in the helm deployment
4 participants