Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cases where CM enabled but no TLS block specified in VS #2718

Merged
merged 1 commit into from
May 25, 2022
Merged

Fix cases where CM enabled but no TLS block specified in VS #2718

merged 1 commit into from
May 25, 2022

Conversation

ciarams87
Copy link
Member

Proposed changes

Fixes #2717

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team May 24, 2022 20:03
@ciarams87 ciarams87 self-assigned this May 24, 2022
@github-actions github-actions bot added the bug An issue reporting a potential bug label May 24, 2022
jjngx
jjngx approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ciarams87 ciarams87 merged commit 7d4f70d into main May 25, 2022
@ciarams87 ciarams87 deleted the fix-cm branch May 25, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx is a code owner automatically assigned from nginxinc/kic

Assignees

@ciarams87 ciarams87

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Controller pods fail with resources without TLS, but with enabled cert-manager integration
3 participants
@ciarams87 @lucacome @jjngx