Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate JWT key, realm and login url for ingress resources annotations #2754

Merged
merged 5 commits into from
Jun 15, 2022

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Jun 14, 2022

Proposed changes

Validate JWT key, realm and login url for ingress resources annotations.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jun 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #2754 (2874623) into main (398e660) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 2874623 differs from pull request most recent head c94f662. Consider uploading reports for the commit c94f662 to get more accurate results

@@            Coverage Diff             @@
##             main    #2754      +/-   ##
==========================================
+ Coverage   53.52%   53.63%   +0.10%     
==========================================
  Files          52       52              
  Lines       14804    14838      +34     
==========================================
+ Hits         7924     7958      +34     
  Misses       6617     6617              
  Partials      263      263              
Impacted Files Coverage Δ
internal/k8s/validation.go 99.17% <100.00%> (+0.08%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@haywoodsh haywoodsh changed the title Validate JWT key, realm and login url Validate JWT key, realm and login url for ingress resources annotations Jun 15, 2022
@haywoodsh haywoodsh marked this pull request as ready for review June 15, 2022 10:14
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@haywoodsh haywoodsh enabled auto-merge (squash) June 15, 2022 20:49
@haywoodsh haywoodsh merged commit d66f9e8 into main Jun 15, 2022
@haywoodsh haywoodsh deleted the feature/validate-jwt branch June 15, 2022 20:52
@ciarams87 ciarams87 added this to the v2.3.0 milestone Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants