Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation regex for path spec #2783

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Jun 22, 2022

Proposed changes

This change updates the regex used to validated the path spec for Ingress and VirtualServer resources

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jun 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #2783 (395479c) into main (8284f4c) will not change coverage.
The diff coverage is n/a.

❗ Current head 395479c differs from pull request most recent head cbf0fbe. Consider uploading reports for the commit cbf0fbe to get more accurate results

@@           Coverage Diff           @@
##             main    #2783   +/-   ##
=======================================
  Coverage   54.04%   54.04%           
=======================================
  Files          53       53           
  Lines       15009    15009           
=======================================
  Hits         8112     8112           
  Misses       6629     6629           
  Partials      268      268           
Impacted Files Coverage Δ
internal/k8s/validation.go 97.79% <ø> (ø)
pkg/apis/configuration/validation/virtualserver.go 94.74% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@shaun-nx shaun-nx marked this pull request as ready for review June 23, 2022 09:49
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@shaun-nx shaun-nx merged commit f882b94 into main Jun 24, 2022
@shaun-nx shaun-nx deleted the feature/path-validation branch June 24, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants