-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integrate ExternalDNS with VirtualServer resources #2800
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2800 +/- ##
==========================================
- Coverage 53.79% 53.08% -0.72%
==========================================
Files 55 58 +3
Lines 15273 15625 +352
==========================================
+ Hits 8216 8294 +78
- Misses 6779 7052 +273
- Partials 278 279 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
cec54a7
to
04925bc
Compare
docs/content/configuration/virtualserver-and-virtualserverroute-resources.md
Outdated
Show resolved
Hide resolved
glog.V(3).Infof("external DNS endpoint resource isnot owned by this object. refusing to update non-owned resource") | ||
return nil, nil, nil | ||
} | ||
if !extdnsendpointNeedsUpdate(existingDNSEndpoint, dnsEndpoint) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this function name to isUpdateRequired
since this function is already in the context of ExternalDNS
40113ef
to
c4b66b4
Compare
c4b66b4
to
4faa900
Compare
4faa900
to
bface28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Proposed changes
This PR creates an
ExternalDNS
block in the VirtualServer resource and uses it to create and configure DNSEndpoint objects which will be picked up an ExternalDNS deployment. ExternalDNS can then use the information in DNSEndpoint object to create, update, or delete, as appropriate, DNS records with the configured provider. See https://kubernetes-sigs.github.io/external-dns/v0.12.0/.Checklist
Before creating a PR, run through this checklist and mark each as complete.