feat: Integrate ExternalDNS with VirtualServer resources #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Codecov Report
@@ Coverage Diff @@
## main #2800 +/- ##
==========================================
- Coverage 53.79% 53.08% -0.72%
==========================================
Files 55 58 +3
Lines 15273 15625 +352
==========================================
+ Hits 8216 8294 +78
- Misses 6779 7052 +273
- Partials 278 279 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ciarams87
force-pushed
the
extdns-controller
branch
from
cec54a7
to
04925bc
Compare
shaun-nx
reviewed
Jun 30, 2022
docs/content/configuration/virtualserver-and-virtualserverroute-resources.md
Outdated
Show resolved
Hide resolved
shaun-nx
reviewed
Jun 30, 2022
shaun-nx
reviewed
Jun 30, 2022
shaun-nx
reviewed
Jun 30, 2022
| glog.V(3).Infof("external DNS endpoint resource isnot owned by this object. refusing to update non-owned resource") | ||
| return nil, nil, nil | ||
| } | ||
| if !extdnsendpointNeedsUpdate(existingDNSEndpoint, dnsEndpoint) { |
There was a problem hiding this comment.
I would change this function name to isUpdateRequired since this function is already in the context of ExternalDNS
ciarams87
force-pushed
the
extdns-controller
branch
4 times, most recently
from
40113ef
to
c4b66b4
Compare
ciarams87
force-pushed
the
extdns-controller
branch
from
c4b66b4
to
4faa900
Compare
ciarams87
force-pushed
the
extdns-controller
branch
from
4faa900
to
bface28
Compare
Merged
haywoodsh
approved these changes
Jul 5, 2022
jjngx
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR creates an
ExternalDNSblock in the VirtualServer resource and uses it to create and configure DNSEndpoint objects which will be picked up an ExternalDNS deployment. ExternalDNS can then use the information in DNSEndpoint object to create, update, or delete, as appropriate, DNS records with the configured provider. See https://kubernetes-sigs.github.io/external-dns/v0.12.0/.Checklist
Before creating a PR, run through this checklist and mark each as complete.