Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing minReadySeconds & strategy chart values in Helm Installation documentation #2853

Merged
merged 6 commits into from
Aug 2, 2022
Merged

Add missing minReadySeconds & strategy chart values in Helm Installation documentation #2853

merged 6 commits into from
Aug 2, 2022

Conversation

aknot242
Copy link
Contributor

Proposed changes

Adds missing minReadySeconds & strategy helm chart values reported in #2852

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@lucacome lucacome added the documentation Pull requests/issues for documentation label Jul 14, 2022
@lucacome lucacome requested review from a team, lucacome, haywoodsh and ciarams87 July 14, 2022 20:19
@lucacome lucacome requested a review from a team July 14, 2022 21:09
@brianehlert brianehlert linked an issue Jul 15, 2022 that may be closed by this pull request
minReadySeconds & strategy chart values are missing from Helm Installation doc #2852
Closed
aknot242 and others added 2 commits July 20, 2022 13:12
@aknot242 @jputrino
Update docs/content/installation/installation-with-helm.md
ec4d602 
Co-authored-by: Jodie Putrino <j.putrino@f5.com>
@aknot242 @jputrino
Update docs/content/installation/installation-with-helm.md
3601362 
Co-authored-by: Jodie Putrino <j.putrino@f5.com>
@lucacome lucacome merged commit a93c710 into nginxinc:main Aug 2, 2022
@aknot242 aknot242 deleted the missing-docs branch August 2, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome lucacome approved these changes

@jputrino jputrino jputrino approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh is a code owner automatically assigned from nginxinc/kic

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minReadySeconds & strategy chart values are missing from Helm Installation doc
5 participants
@aknot242 @lucacome @jputrino @ciarams87 @jjngx