Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialDelaySeconds to helm charts #2854

Merged
merged 6 commits into from
Aug 29, 2022

Conversation

aknot242
Copy link
Contributor

Proposed changes

Adds initialDelaySeconds for readiness probe to Helm charts. Addresses #2850
Additionally, addresses a few template formatting issues.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@brianehlert brianehlert linked an issue Jul 15, 2022 that may be closed by this pull request
Co-authored-by: Luca Comellini <luca.com@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2022

Codecov Report

Merging #2854 (650175d) into main (7089925) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2854      +/-   ##
==========================================
+ Coverage   53.02%   53.03%   +0.01%     
==========================================
  Files          58       58              
  Lines       15645    15645              
==========================================
+ Hits         8296     8298       +2     
  Misses       7070     7070              
+ Partials      279      277       -2     
Impacted Files Coverage Δ
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️
internal/k8s/configuration.go 95.76% <0.00%> (+0.36%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome self-assigned this Aug 29, 2022
@lucacome lucacome requested review from a team, lucacome, haywoodsh and shaun-nx August 29, 2022 16:42
@lucacome lucacome added this to the v2.4.0 milestone Aug 29, 2022
@lucacome lucacome added the enhancement Pull requests for new features/feature enhancements label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a readiness probe delay value in Helm chart
5 participants