Add fetch custom NGINX template from ConfigMap #303
Merged
+248
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
Dean-Coakley
force-pushed
the
template-configmap
branch
from
1922bb6
to
1144d00
Compare
pleshakov
suggested changes
Jul 11, 2018
nginx-controller/nginx/nginx.go
Outdated
| } | ||
| // UpdateIngressConfigFile writes the Ingress configuration file to the filesystem | ||
| func (nginx *NginxController) UpdateIngressConfigFile(name string, cfg []byte) { | ||
| filename := nginx.getIngressNginxConfigFileName(name) // "/etc/nginx/nginx.ingress.conf" |
There was a problem hiding this comment.
please remove the comment // "/etc/nginx/nginx.ingress.conf"
| "text/template" | ||
| ) | ||
|
|
||
| // TemplateExecutor generates, executes NGINX configuration templates |
There was a problem hiding this comment.
TemplateExecutor does not generate
Dean-Coakley
force-pushed
the
template-configmap
branch
4 times, most recently
from
0a87142
to
f57d6bb
Compare
pleshakov
approved these changes
Jul 12, 2018
Dean-Coakley
force-pushed
the
template-configmap
branch
from
f57d6bb
to
a636f5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom templates can now be set on startup or updated via ConfigMap
Custom template via ConfigMap on startup
Custom template via ConfigMap update
Example in documentation
Updated ConfigMap/Annotations table
Invalid template or invalid NGINX configuration on startup causes Ingress Controller to stop, and logs the error.
Invalid template or invalid NGINX configuration update does not apply any configuration changes, and logs the error.