Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow omitting the default server secret from Helm installs #3087

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

ciarams87
Copy link
Member

Proposed changes

Allow omitting the default server secret from Helm installs. If no kubernetes secret is defined for the default_server, the NGINX directive ssl_reject_handshake will be enabled for default_server. Currently, we try and create a secret for the default server if one is not provided, and will throw an error if the cert and key parameters are not provided. This change supports setting them to empty strings and omitting the CLI command if this is so.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested review from a team, lucacome, jjngx and shaun-nx September 22, 2022 10:06
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Pull requests/issues for documentation labels Sep 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #3087 (6350cb3) into main (17aad37) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 6350cb3 differs from pull request most recent head c45bd79. Consider uploading reports for the commit c45bd79 to get more accurate results

@@            Coverage Diff             @@
##             main    #3087      +/-   ##
==========================================
- Coverage   52.29%   52.28%   -0.02%     
==========================================
  Files          58       58              
  Lines       16006    16006              
==========================================
- Hits         8371     8369       -2     
- Misses       7356     7358       +2     
  Partials      279      279              
Impacted Files Coverage Δ
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ciarams87 ciarams87 force-pushed the chore/allow-omit-default-secret branch from 43440d3 to 487df71 Compare September 22, 2022 17:10
Copy link
Contributor

@vepatel vepatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@ciarams87 ciarams87 force-pushed the chore/allow-omit-default-secret branch from 6350cb3 to c45bd79 Compare September 26, 2022 08:24
@ciarams87 ciarams87 merged commit 2f6dd78 into main Sep 26, 2022
@ciarams87 ciarams87 deleted the chore/allow-omit-default-secret branch September 26, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants