chore: Allow omitting the default server secret from Helm installs #3087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allow omitting the default server secret from Helm installs. If no kubernetes secret is defined for the default_server, the NGINX directive ssl_reject_handshake will be enabled for default_server. Currently, we try and create a secret for the default server if one is not provided, and will throw an error if the cert and key parameters are not provided. This change supports setting them to empty strings and omitting the CLI command if this is so.
Checklist
Before creating a PR, run through this checklist and mark each as complete.